Skip to content

Conversation

@Mark5900
Copy link
Owner

@Mark5900 Mark5900 commented Dec 2, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #455, which was a critical bug where the function was returning an undefined variable. The main fix involves correcting the return statement (from $oaUnit to proper pipeline output), and additionally enhances the function with pipeline support and improved code readability.

Key changes:

  • Bug fix: Removed incorrect Return $oaUnit statement that referenced a non-existent variable (the variable was actually $oaUnits)
  • Pipeline support: Added ValueFromPipeline = $true parameter attribute and wrapped logic in a process block
  • Code refactoring: Replaced manual array accumulation with ForEach-Object pipeline pattern for cleaner, more PowerShell-idiomatic code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ons.ps1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Mark5900 Mark5900 merged commit 7994d19 into Prerelease Dec 2, 2025
@Mark5900 Mark5900 deleted the bug-fixes branch December 2, 2025 17:15
@ignore-branch-protection
Copy link

🎉 This PR is included in version 1.15.0-Prerelease.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ignore-branch-protection
Copy link

🎉 This PR is included in version 1.15.1-Prerelease.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ignore-branch-protection
Copy link

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants