Skip to content

Update nodejs version for MarkBind v4 release #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahtanjz merged 1 commit into from
Jul 18, 2022
Merged

Update nodejs version for MarkBind v4 release #7

jonahtanjz merged 1 commit into from
Jul 18, 2022

Conversation

@tlylt
Copy link
Collaborator

@tlylt tlylt commented Jul 17, 2022

Fixes #5

Update nodejs version for MarkBind V4

Since the release of MarkBind V4, nodejs version has been
updated to V14.

Let's update the action configurations to install nodejs V14.

This will make the action compatible with future MarkBind V4
version updates.

@tlylt tlylt requested a review from jonahtanjz July 17, 2022 14:43
jonahtanjz
jonahtanjz approved these changes Jul 18, 2022
View reviewed changes
Copy link

@jonahtanjz jonahtanjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlylt

LGTM 👍

@jonahtanjz jonahtanjz merged commit b485156 into MarkBind:master Jul 18, 2022
@tlylt
Copy link
Collaborator Author

tlylt commented Jul 18, 2022

Thanks @tlylt

LGTM 👍

Thanks @jonahtanjz, will make a follow-up patch release later for this so that v2 is up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahtanjz jonahtanjz jonahtanjz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade Node version

2 participants

@tlylt @jonahtanjz