Skip to content

Update documentation on using raw HTML in dropdown#1013

Closed
le0tan wants to merge 1 commit intoMarkBind:masterfrom
le0tan:embed-html-doc
Closed

Update documentation on using raw HTML in dropdown#1013
le0tan wants to merge 1 commit intoMarkBind:masterfrom
le0tan:embed-html-doc

Conversation

@le0tan
Copy link
Contributor

@le0tan le0tan commented Feb 3, 2020

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Resolves #1003

@le0tan le0tan requested a review from yamgent February 3, 2020 04:05
Copy link
Member

@yamgent yamgent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raw HTML in dropdown is only available since v2.9.1 (which included v2.0.1-markbind.32). Your branch was outdated so it was using v2.9.0.

I have manually rebased the branch on my local repo to verify that the changes work (not reflected in PR right now), but for future references you might want to rebase branches to the latest possible, so that future reviewers will be able to easily check your changes, without having to locally checkout your branch.


On another note, I realised that dropdown has never supported any form of markdown at all. Therefore, we weren't able to do something like this:

<dropdown text="**Strong text**" type="warning">

I am raising this because should markdown be accepted, then there's really no reason why we should encourage the authors to follow the examples actually, since it diverts them away from using markdown syntax, and asking them to use raw HTML instead.

I am wondering whether we should seek to implement markdown in dropdown, and introduce slots to allow additional customization, rather than just supporting raw HTML like now. @ang-zeyu what do you think?

@le0tan
Copy link
Contributor Author

le0tan commented Feb 6, 2020

#1029
@yamgent I made the suggested implementation, if it looks OK I'll write documentation to that in the new PR and you may close this PR.

@ang-zeyu
Copy link
Contributor

ang-zeyu commented Feb 6, 2020

I am wondering whether we should seek to implement markdown in dropdown, and introduce slots to allow additional customization

Sounds good; 👍

I don't think we should include any extra slots, since the design of dropdowns aren't suited for containing much other than inline markdown. Though, I may've yet to think of a use case for it.

@le0tan
Copy link
Contributor Author

le0tan commented Feb 16, 2020

PR closed due to more updated version at #1029

@le0tan le0tan closed this Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation for embedded HTML in dropdown component

3 participants