Add example for using multiple features in code-blocks#1102
Merged
marvinchin merged 10 commits intoMarkBind:masterfrom Mar 11, 2020
Merged
Add example for using multiple features in code-blocks#1102marvinchin merged 10 commits intoMarkBind:masterfrom
marvinchin merged 10 commits intoMarkBind:masterfrom
Conversation
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
* 'master' of https://github.com/MarkBind/markbind: 2.12.0 Update outdated test files Update vue-strap version to v2.0.1-markbind.37 Fix refactor to processDynamicResources (MarkBind#1092) Implement lazy page building for markbind serve (MarkBind#1038) Add warnings for conflicting/deprecated component attribs (MarkBind#1057) Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062)
Tejas2805
changed the title
Contributor
Author
|
@marvinchin Can I get your review on this. Thank you for your time. |
nbriannl
requested changes
Mar 9, 2020
nbriannl
requested changes
Mar 9, 2020
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
Co-Authored-By: nbriannl <neilbrian.nl@gmail.com>
nbriannl
requested changes
Mar 10, 2020
Contributor
nbriannl
left a comment
nbriannl
left a comment
There was a problem hiding this comment.
Looks good except for one nit. 😅
nbriannl
approved these changes
Mar 10, 2020
Contributor
nbriannl
left a comment
nbriannl
left a comment
There was a problem hiding this comment.
LGTM. Thank you for raising up that you couldn't understand how to use multiple features.
marvinchin
approved these changes
Mar 11, 2020
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 15, 2020
* 'master' of https://github.com/MarkBind/markbind: Add example for using multiple features in code-blocks (MarkBind#1102)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
The user will have to try out how to add multiple features when using code blocks. Let's add an example regarding how to use multiple features in code blocks so that it's easier for the user to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
Fixes #1098
What is the rationale for this request?
Easier for the users to understand how to add multiple features while using code blocks.
What changes did you make? (Give an overview)
Added an example which displays how to use multiple features in code blocks.
Provide some example code that this change will affect:
N.A.
Is there anything you'd like reviewers to focus on?
N.A.
Testing instructions:
Can check the deployed preview.
Proposed commit message: (wrap lines at 72 characters)