Fix links in contributing.md and add code of conduct to siteNav#1170
Fix links in contributing.md and add code of conduct to siteNav#1170nbriannl merged 1 commit intoMarkBind:masterfrom
Conversation
|
Can't seem to link to code-of-conduct even though it shows up on netifly https://deploy-preview-1170--markbind-master.netlify.com/devguide/contributing/code-of-conduct ... 😞 https://markbind.org/devdocs/devGuide/devGuide.html#requirement Update: I forgot to update |
Edit: Resolved. Spelt
|
le0tan
left a comment
There was a problem hiding this comment.
Looks like code of conduct is accessible only from direct URL access of clicing the link in "Contributing" page. Would is be better if code of conduct is shown on the left navigation? Otherwise LGTM.
Think i'll leave this as a good first issue for any newcomer this summer. Edit: After thinking about, i think it's better to just do a quick change since i'm already here |
Oh. My bad. |

What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
• [X] Bug fix
What is the rationale for this request?
Preview in #1139 showed correctly, but links are broken in actual site.
What changes did you make? (Give an overview)
Comparing the output resolved href in the deployed site code,
https://github.com/MarkBind/devdocs/blob/a43131f3fed86576c821e1a92696ece77b1768f3/devGuide/contributing.html#L61
I can conclude
{{baseUrl}}/devGuide/contributing/code-of-conduct.htmlresolved correctly to/devdocs/devGuide/contributing/code-of-conduct.htmlThe reason why the code-of-conduct page was broken was because I forgot to configure
docs/dg-site.json, hence it wasn't generated in the deployed site.I incorrectly used
baseurlinstead ofbaseUrl. (This error did not show up in netifly and was not caught by anyone). Changed it accordingly. I believe that the rest of the links should now resolve correctly as well.Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
Testing instructions:
Compare broken links in https://markbind.org/devdocs/devGuide/contributing.html, and see if the corresponding links send to the correct pages
Proposed commit message: (wrap lines at 72 characters)
Fix contributing.md links, update siteNav
Fix baseurl to baseUrl and added Code of Conduct to siteNav