[v2] Fix anchor navigation in panel headers#1191
Conversation
|
Some conflicts @le0tan |
|
@ang-zeyu looks like you removed some pointer events from |
Refer to the second commit in #1129. It's moved to plugin css ( new feature ) |
|
@ang-zeyu got it and I changed my code accordingly, can you take a look? |
|
@le0tan there's still a large amount of conflicts, mostly from previous versions |
| @@ -32,20 +32,18 @@ function setupAnchorsForFixedNavbar() { | |||
| jQuery('#content-wrapper').css('padding-top', `calc(${headerHeight}px)`); | |||
There was a problem hiding this comment.
would it be possible to just insert the padding for the main container and not its 3 sub containers?
There was a problem hiding this comment.
As far as I'm concerned it doesn't work...
There was a problem hiding this comment.
ok, might be better to leave it this way as well: .css('nav-inner') needs to be offsetted with the original padding
There was a problem hiding this comment.
just did that, wondering if we need to add 1rem to content-wrapper as well, but probably better leave it as a future first timer issue?
There was a problem hiding this comment.
Good idea, would make it seem less squeezed to the top. Let's leave it as a first timer issue then, though if you want to include it here it'd be nice as well
damithc
left a comment
damithc
left a comment
There was a problem hiding this comment.
Looks good, but my review is from the author POV only.
| @@ -32,20 +32,18 @@ function setupAnchorsForFixedNavbar() { | |||
| jQuery('#content-wrapper').css('padding-top', `calc(${headerHeight}px)`); | |||
There was a problem hiding this comment.
Good idea, would make it seem less squeezed to the top. Let's leave it as a first timer issue then, though if you want to include it here it'd be nice as well
3 participants
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
• [X] Bug fix
Replaces #1145 #1187
Fixes #1104 Fixes #1071
What changes did you make? (Give an overview)
Move span generation to a plugin during build time. Add
::beforeto panel card containers to make navigation work properly on panel headers.Provide some example code that this change will affect:
na
Is there anything you'd like reviewers to focus on?
Test if the panel functions are broken in any way.
Testing instructions:
na
Proposed commit message: (wrap lines at 72 characters)
To avoid dynamically injecting lots of dummy spans in a document with
many headings, let's generate these spans at build time.
To make anchor navigation function properly on panel headers, let's
introduce ::before element to
card-containerto make space for thefixed top nav.