Change format of nunjucks code and output #2175
Conversation
lhw-1
left a comment
lhw-1
left a comment
There was a problem hiding this comment.
Good find & thanks for working on it @yucheng11122017! Seems to work on my end 👍
Current boiler plates will not work with nunjucks due to the need for {%raw%} and {%endraw%} tags to escape the nunjucks.
Just to check, you are referring to #2119, right? For now, since this is a viable workaround, maybe we can document this somewhere (or at least mention it in #2119) in case developers run into this exact problem in the future.
| %%OUTPUT:%% | ||
| <div class="indented"> | ||
|
|
||
| <box border-left-color={{ markbind_blue }} background-color="white"> |
There was a problem hiding this comment.
May I know if this part of the codeAndOutput.md boilerplate appears blue on your end? The default boilerplate seems to appear grey on my end:
Or is there a reason why we are changing it to blue specifically?
There was a problem hiding this comment.
Apologies, fixed in 479dd7d. I was working on a PR which changes it to blue
Oh yes there are overlaps with #2119. I'm not sure if this would be considered a workaround though since its still not a boilerplate. |
jovyntls
left a comment
jovyntls
left a comment
There was a problem hiding this comment.
LGTM, nice that we're improving the consistency of our UG!
Is there a need to create a new boilerplate just for nunjucks? Current boiler plates will not work with nunjucks due to the need for {%raw%} and {%endraw%} tags to escape the nunjucks.
Currently only one usage of nunjucks code and output which will be corrected in this PR
IMO If this is the only usage of nunjucks code I think it's fine without a boilerplate :) (Though if we do manage to make the boilerplate work with nunjucks too, that's be great)
…xUgNunjuckCodeOutputFormat
3 participants
…t.md boilerplate
What is the purpose of this pull request?
Overview of changes:
Currently in UG:
Changed to :
This is to be consistent with other code output formatting in the documentation
Anything you'd like to highlight/discuss:
Is there a need to create a new boilerplate just for nunjucks? Current boiler plates will not work with nunjucks due to the need for {%raw%} and {%endraw%} tags to escape the nunjucks.
Currently only one usage of nunjucks code and output which will be corrected in this PR
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Change format of nunjucks code and output in UG
Checklist: ☑️