Skip to content

Conversation

@jovyntls
Copy link
Contributor

@jovyntls jovyntls commented Mar 8, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrates 4 default plugins to TS:

  • markbind-plugin-anchors.js
  • markbind-plugin-plantuml.js
  • markbind-plugin-shorthandSyntax.js
  • markbind-plugin-tree.js

Anything you'd like to highlight/discuss:
N/A

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)
(rebase commit)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jovyntls jovyntls force-pushed the ts-migrate-default-plugins branch from 1ad6133 to e33351c Compare March 8, 2023 11:02
@jovyntls jovyntls marked this pull request as ready for review March 8, 2023 11:02
@jovyntls jovyntls force-pushed the ts-migrate-default-plugins branch 2 times, most recently from f9fd09e to cbd092f Compare March 14, 2023 06:02
@tlylt tlylt requested a review from a team March 15, 2023 12:01
Copy link
Contributor

@itsyme itsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @jovyntls! LGTM!

@jovyntls jovyntls force-pushed the ts-migrate-default-plugins branch 2 times, most recently from ba9f077 to 43071db Compare March 17, 2023 10:24
@jovyntls jovyntls force-pushed the ts-migrate-default-plugins branch from a828ab2 to 4bfa855 Compare March 20, 2023 09:02
@jovyntls jovyntls requested review from raysonkoh and tlylt March 21, 2023 01:34
@jovyntls jovyntls changed the title Migrate default plugins to TS Migrate default plugins to TypeScript Mar 21, 2023
Copy link
Contributor

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovyntls jovyntls merged commit 88856fb into MarkBind:master Mar 21, 2023
@jovyntls jovyntls deleted the ts-migrate-default-plugins branch March 21, 2023 09:27
Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jovyntls, I think looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants