-
Notifications
You must be signed in to change notification settings - Fork 140
Generate .gitignore on init command #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jovyntls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lhw-1 , just one clarification!
|
Would be good to add a note in https://markbind-master.netlify.app/userguide/gitignorefile to explain this new behavior |
Added, and also updated the |
jovyntls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just documentation nits!
jovyntls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lhw-1 !
What is the purpose of this pull request?
Breaking Change Overview:
A
.gitignorefile is now added by themarkbind initcommand by default.This file is only generated when initializing a new MarkBind site from scratch, and not when converting a set of pre-existing documents into a MarkBind site using
markbind init --convert. As such, this does not require any additional actions from the user.Overview of changes:
Resolves #1782, and is a breaking change.
TODOs as listed by the original issue:
.gitignorewhenmarkbind initis called.gitignoregeneration for the--convertflagAnything you'd like to highlight/discuss:
This adds a
.gitignoreto thedefaulttemplate (only).The proposed implementation is to skip the
.gitignoregeneration whenmarkbind initis called with--convertflag, but in the future, there may be a need for another action (e.g. merge / overwrite). In this case, please refer to the discussions in #1782 for the rationale on why merging / overwriting may not be a good idea. Also refer to the implementation here if needed.The original issue suggests a potential extension to generate a
package.jsonas well.Testing instructions:
Pull this PR and call
markbind init. Check that.gitignoreis generated when callingmarkbind init, but not when using the--convertflag.Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️