Remove includes with variables #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EltonGohJH
reviewed
Mar 31, 2023
lhw-1
reviewed
Mar 31, 2023
Contributor
lhw-1
left a comment
lhw-1
left a comment
There was a problem hiding this comment.
LGTM!
Should we update the UG (Includes section) to document this?
Contributor
Author
Mmmm may be better to not reveal our weaknesses? :) |
Contributor
It's OK to document limitations but should be done in a way that most readers don't need to read about it. Only those who are encountering this kind of use case should need to read about it. |
Contributor
Author
Alright I will open a separate PR for this :) |
…moveIncludeWithVariables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Removes includes of variables in UG due to #2211
Checked through the rest of UG and DG to see if there was any other instance of this use case.
Overview of changes:
Removes includes with variables and replaces it with the actual code.
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Remove include of variables in UG
Checklist: ☑️