Skip to content

Specify Netlify build settings #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlylt merged 1 commit into from
Apr 12, 2023
Merged

Specify Netlify build settings #2277

tlylt merged 1 commit into from
Apr 12, 2023

Conversation

@tlylt
Copy link
Contributor

@tlylt tlylt commented Apr 10, 2023 •
edited
Loading

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Fixes #2189

Expose and specify netlify settings for building markbind-master, to reduce the need to have exclusive access to the netlify team account for making config changes.

Anything you'd like to highlight/discuss:

Testing instructions:
See netlify logs for the PR preview (which is going to be similar to the actual one):

7:18:54 PM: build-image version: 596993885fcc8df0dd6d507c57c5c9cb7c3a8576 (focal)
7:18:54 PM: buildbot version: 163fe70070e26a02d64141bf435d02320d25b8c1
7:18:54 PM: Building without cache
7:18:54 PM: Starting to prepare the repo for build
7:18:54 PM: No cached dependencies found. Cloning fresh repo
7:18:54 PM: git clone --filter=blob:none https://github.com/MarkBind/markbind
7:18:54 PM: Preparing Git Reference pull/2277/head
7:18:56 PM: Parsing package.json dependencies
7:18:57 PM: Different build command detected, going to use the one specified in the Netlify configuration file: 'npm run deploy:netlify' versus 'npm run setup && npm run build:web && cd docs && node ../packages/cli/index.js build --baseUrl' in the Netlify UI
7:18:58 PM: Starting to install dependencies
7:18:58 PM: Python version set to 3.8
7:18:58 PM: Attempting Ruby version 2.7.2, read from environment
7:18:58 PM: Using Ruby version 2.7.2
7:18:59 PM: Started restoring cached go cache
7:18:59 PM: Finished restoring cached go cache
7:18:59 PM: Installing Go version 1.19.5 (requested 1.19.5)
7:19:03 PM: go version go1.19.5 linux/amd64
7:19:04 PM: Using PHP version 8.0
7:19:05 PM: Downloading and installing node v16.19.1...
7:19:05 PM: Downloading https://nodejs.org/dist/v16.19.1/node-v16.19.1-linux-x64.tar.xz...
7:19:05 PM: Computing checksum with sha256sum
7:19:05 PM: Checksums matched!
7:19:07 PM: Now using node v16.19.1 (npm v8.19.3)
7:19:07 PM: Enabling Node.js Corepack
7:19:07 PM: Started restoring cached build plugins
7:19:07 PM: Finished restoring cached build plugins
7:19:07 PM: Started restoring cached corepack dependencies
7:19:07 PM: Finished restoring cached corepack dependencies
7:19:07 PM: npm workspaces detected
7:19:08 PM: Installing npm packages using npm version 8.19.3
7:19:12 PM: npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
7:19:12 PM: npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
7:19:13 PM: npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.npm WARN deprecated trim@0.0.1: Use String.prototype.trim() instead
7:19:13 PM: npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
7:19:13 PM: npm WARN deprecated opn@6.0.0: The package has been renamed to open
7:19:16 PM: npm WARN deprecated @types/vfile-message@2.0.0: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.
7:19:16 PM: npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
7:19:17 PM: npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
7:19:18 PM: npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
7:19:18 PM: npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
7:19:19 PM: npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
7:19:19 PM: npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
7:19:21 PM: npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
7:19:30 PM: added 2082 packages, and audited 2087 packages in 22s
7:19:30 PM: 215 packages are looking for funding
7:19:30 PM: run npm fund for details
7:19:30 PM: 20 vulnerabilities (1 moderate, 18 high, 1 critical)
7:19:30 PM: To address all issues (including breaking changes), run:
7:19:30 PM: npm audit fix --force
7:19:30 PM: Run npm audit for details.
7:19:30 PM: npm packages installed
7:19:30 PM: Install dependencies script success
7:19:30 PM: Starting build script
7:19:31 PM: Detected 0 framework(s)
7:19:31 PM: Section completed: initializing
7:19:32 PM: ​
7:19:32 PM: Netlify Build
7:19:32 PM: ────────────────────────────────────────────────────────────────
7:19:32 PM: ​
7:19:32 PM: ❯ Version
7:19:32 PM: @netlify/build 29.9.0
7:19:32 PM: ​
7:19:32 PM: ❯ Flags
7:19:32 PM: baseRelDir: false
7:19:32 PM: buildId: 6433f09a06fb26068128dff5
7:19:32 PM: deployId: 6433f09a06fb26068128dff7
7:19:32 PM: ​
7:19:32 PM: ❯ Current directory
7:19:32 PM: /opt/build/repo
7:19:32 PM: ​
7:19:32 PM: ❯ Config file
7:19:32 PM: /opt/build/repo/netlify.toml
7:19:32 PM: ​
7:19:32 PM: ❯ Context
7:19:32 PM: deploy-preview
7:19:32 PM: ​
7:19:32 PM: 1. build.command from netlify.toml
7:19:32 PM: ────────────────────────────────────────────────────────────────
7:19:32 PM: ​
7:19:32 PM: $ npm run deploy:netlify
7:19:32 PM: > deploy:netlify
7:19:32 PM: > npm run setup && npm run build:web && cd docs && node ../packages/cli/index.js build --baseUrl
7:19:33 PM: > setup
7:19:33 PM: > npm ci && npm run clean && lerna run prepare
7:19:39 PM: npm WARN deprecated @types/vfile-message@2.0.0: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.
7:19:40 PM: npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
7:19:40 PM: npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
7:19:40 PM: npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
7:19:40 PM: npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
7:19:40 PM: npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
7:19:40 PM: npm WARN deprecated trim@0.0.1: Use String.prototype.trim() instead
7:19:40 PM: npm WARN deprecated opn@6.0.0: The package has been renamed to open
7:19:40 PM: npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
7:19:40 PM: npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
7:19:41 PM: npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
7:19:41 PM: npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
7:19:43 PM: npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
7:19:51 PM: added 2067 packages, and audited 2087 packages in 19s
7:19:51 PM: 215 packages are looking for funding
7:19:51 PM: run npm fund for details
7:19:51 PM: 20 vulnerabilities (1 moderate, 18 high, 1 critical)
7:19:51 PM: To address all issues (including breaking changes), run:
7:19:51 PM: npm audit fix --force
7:19:51 PM: Run npm audit for details.
7:19:52 PM: > clean
7:19:52 PM: > node ./scripts/clean.js
7:19:52 PM: lerna notice cli v6.6.1
7:19:52 PM: lerna info ci enabled
7:19:53 PM: > @markbind/core:prepare
7:19:53 PM: > @markbind/core@4.1.0 prepare
7:19:53 PM: > npm run build
7:19:53 PM: > @markbind/core@4.1.0 build
7:19:53 PM: > tsc --noEmitOnError
7:19:59 PM: > Lerna (powered by Nx) Successfully ran target prepare for project @markbind/core
7:20:00 PM: > build:web
7:20:00 PM: > cd packages/core-web && npm run build
7:20:00 PM: > @markbind/core-web@4.1.0 build
7:20:00 PM: > npm run build:client && npm run build:server
7:20:00 PM: > @markbind/core-web@4.1.0 build:client
7:20:00 PM: > cross-env ENTRY_POINT=client webpack --progress --no-stats --config webpack.build.js
omitted some stuff
7:20:13 PM: ]0; MarkBind� __ __ _ ____ _ _
7:20:13 PM: | / | __ _ _ __ | | __ | __ ) () _ __ __| |
7:20:13 PM: | |/| | / | | '__| | |/ / | _ \ | | | '_ \ / _ |
7:20:13 PM: | | | | | (| | | | | < | |) | | | | | | | | (| |
7:20:13 PM: || || _,| || ||_\ |/ || || || _,|
7:20:13 PM:
7:20:13 PM: v4.1.0
7:20:13 PM: info: Website generation started at 11:20:13 AM
7:20:13 PM: info: Building assets...
7:20:13 PM: info: Assets built
7:20:13 PM: info: Generating pages...
7:20:21 PM: Starting post processing
7:20:20 PM: [-----------------------------------------------------------] 0 / 60 pages built[=----------------------------------------------------------] 1 / 60 pages built[==---------------------------------------------------------] 2 / 60 pages built[===--------------------------------------------------------] 3 / 60 pages built[====-------------------------------------------------------] 4 / 60 pages built[=====------------------------------------------------------] 5 / 60 pages built[======-----------------------------------------------------] 6 / 60 pages built[=======----------------------------------------------------] 7 / 60 pages built[========---------------------------------------------------] 8 / 60 pages built[==========------------------------------------------------] 10 / 60 pages built[===========-----------------------------------------------] 11 / 60 pages built[============----------------------------------------------] 12 / 60 pages built[=============---------------------------------------------] 13 / 60 pages built[==============--------------------------------------------] 14 / 60 pages built[===============-------------------------------------------] 15 / 60 pages built[===============-------------------------------------------] 16 / 60 pages built[================------------------------------------------] 17 / 60 pages built[=================-----------------------------------------] 18 / 60 pages built[==================----------------------------------------] 19 / 60 pages built[=====================-------------------------------------] 22 / 60 pages built[======================------------------------------------] 23 / 60 pages built[=======================-----------------------------------] 24 / 60 pages built[========================----------------------------------] 25 / 60 pages built[=========================---------------------------------] 26 / 60 pages built[==========================--------------------------------] 27 / 60 pages built[===========================-------------------------------] 28 / 60 pages built[============================------------------------------] 29 / 60 pages built[=============================-----------------------------] 30 / 60 pages built[==============================----------------------------] 31 / 60 pages built[===============================---------------------------] 32 / 60 pages built[================================--------------------------] 33 / 60 pages built[=================================-------------------------] 34 / 60 pages built[==================================------------------------] 35 / 60 pages built[===================================-----------------------] 36 / 60 pages built[=====================================---------------------] 38 / 60 pages built[======================================--------------------] 39 / 60 pages built[=======================================-------------------] 40 / 60 pages built[=========================================-----------------] 42 / 60 pages built[===========================================---------------] 44 / 60 pages built[============================================--------------] 45 / 60 pages built[============================================--------------] 46 / 60 pages built[=============================================-------------] 47 / 60 pages built[==============================================------------] 48 / 60 pages built[===============================================-----------] 49 / 60 pages built[================================================----------] 50 / 60 pages built[==================================================--------] 52 / 60 pages built[===================================================-------] 53 / 60 pages built[====================================================------] 54 / 60 pages built[=====================================================-----] 55 / 60 pages built[======================================================----] 56 / 60 pages built[=======================================================---] 57 / 60 pages built[=========================================================-] 59 / 60 pages built[==========================================================] 60 / 60 pages built
7:20:20 PM: info: Pages built
7:20:21 PM: Post processing - HTML
7:20:20 PM: info: Site data built
7:20:20 PM: info: Website generation complete! Total build time: 7.179s
7:20:20 PM: info: Build success!
7:20:20 PM: ​
7:20:20 PM: (build.command completed in 48.2s)
7:20:20 PM: ​
7:20:20 PM: 2. Deploy site
7:20:20 PM: ────────────────────────────────────────────────────────────────
7:20:20 PM: ​
7:20:20 PM: Starting to deploy site from 'docs/_site'
7:20:20 PM: Calculating files to upload
7:20:21 PM: 117 new files to upload
7:20:21 PM: 0 new functions to upload
7:20:21 PM: Section completed: deploying
7:20:21 PM: Site deploy was successfully initiated
7:20:21 PM: ​
7:20:21 PM: (Deploy site completed in 774ms)
7:20:21 PM: ​
7:20:21 PM: Netlify Build Complete
7:20:21 PM: ────────────────────────────────────────────────────────────────
7:20:21 PM: ​
7:20:21 PM: (Netlify Build completed in 49s)
7:20:21 PM: Caching artifacts
7:20:21 PM: Started saving node modules
7:20:21 PM: Finished saving node modules
7:20:21 PM: Started saving build plugins
7:20:21 PM: Finished saving build plugins
7:20:21 PM: Started saving corepack cache
7:20:21 PM: Finished saving corepack cache
7:20:21 PM: Started saving pip cache
7:20:21 PM: Finished saving pip cache
7:20:21 PM: Started saving emacs cask dependencies
7:20:21 PM: Finished saving emacs cask dependencies
7:20:21 PM: Started saving maven dependencies
7:20:21 PM: Finished saving maven dependencies
7:20:21 PM: Started saving boot dependencies
7:20:22 PM: Finished saving boot dependencies
7:20:22 PM: Started saving rust rustup cache
7:20:22 PM: Finished saving rust rustup cache
7:20:22 PM: Started saving go dependencies
7:20:22 PM: Finished saving go dependencies
7:20:22 PM: Build script success
7:20:22 PM: Section completed: building
7:20:23 PM: Uploading Cache of size 233.4MB
7:20:25 PM: Section completed: cleanup
7:20:25 PM: Finished processing build request in 1m31.637s
7:20:26 PM: Post processing - header rules
7:20:26 PM: Post processing - redirect rules
7:20:26 PM: Post processing done
7:20:27 PM: Section completed: postprocessing
7:20:27 PM: Site is live ✨

Proposed commit message: (wrap lines at 72 characters)
Specify Netlify build settings

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

ong6
ong6 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ong6 ong6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlylt tlylt added this to the v4.1.1 milestone Apr 12, 2023
@tlylt tlylt changed the title specify netlify build settings Specify Netlify build settings Apr 12, 2023
@tlylt tlylt merged commit d2314f9 into MarkBind:master Apr 12, 2023
@tlylt tlylt mentioned this pull request Apr 15, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ong6 ong6 ong6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.1.1

Development

Successfully merging this pull request may close these issues.

Expose netlify build command in package.json

2 participants

@tlylt @ong6