Fix stray space before popover and tooltip#2486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2486 +/- ##
=======================================
Coverage 51.11% 51.11%
=======================================
Files 124 124
Lines 5355 5355
Branches 1152 1152
=======================================
Hits 2737 2737
Misses 2328 2328
Partials 290 290 ☔ View full report in Codecov by Sentry. |
This reverts commit 1a5af81.
EltonGohJH
left a comment
There was a problem hiding this comment.
LGTM!
Good job in finding a solution to this bug.
I am just thinking whether we can do better as I think that future devs may be confuse why there is a comment there. Maybe gitblame will be enough but I am thinking whether we can do more.
I agree, not obvious and could be accidentally deleted in the future. @yiwen101 could you note the reason inside the comment pls? |
|
@tlylt @EltonGohJH |
|
@kaixin-hc Each PR must have a SEMVER impact label, please remember to label the PR properly. |
What is the purpose of this pull request?
Overview of changes:
Resolve #2419, modified vue(modification made at minimal scope via trial and error) and add test;
Credit to @kaixin-hc for investigating the cause of the bug.
Anything you'd like to highlight/discuss:
Testing instructions:
Test with
markbind serve -dProposed commit message: (wrap lines at 72 characters)
Fix stray space before popover and tooltip
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):