baseUrl's value sometimes wrong when referencing inner website's content #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes #262.
What is the rationale for this request?
When including files belonging to an inner website, the computation of
baseUrlis wrong if the depth of the inclusion is only 1.What changes did you make? (Give an overview)
Fixed the logic of the algorithm such that the computation of
baseUrlis correct regardless of how deep the inclusion is.Provide some example code that this change will affect:
https://github.com/yamgent/markbind-problems/tree/master/issue_262
Is there anything you'd like reviewers to focus on?
The soundness of the fix.
Testing instructions:
issue_262directory.markbind serve.This is cheese's baseUrl: /main_website/inner_site.a. In the buggy version, the first entry will show
This is cheese's baseUrl: /main_website.