many changes, much cleanup#5
Open
skandragon wants to merge 4 commits intoMarkEMarkEMark:masterfrom
skandragon:master
Open
many changes, much cleanup#5skandragon wants to merge 4 commits intoMarkEMarkEMark:masterfrom skandragon:master
skandragon wants to merge 4 commits intoMarkEMarkEMark:masterfrom
skandragon:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues with the code, namely the multiple definitions of PI, and using uint8_t as an index into a string group which limits the count to 256 bulbs. Also, this moves the need for a broadcast bulb into the specific implementation, rather than the common base class as only physical strings have a broadcast bulb.
There are lots of other code cleanup changes, and bug fixes which will cause the random strobe code to work with more than 100 bulbs(basically re-enabling most of the random runtime generation code) and an actual bug fix for StringGroup::AddString().