Add alias support similiar to robotframework-requests library#149
Add alias support similiar to robotframework-requests library#149nczita wants to merge 3 commits intoMarketSquare:masterfrom
Conversation
| robotframework>=3.0 | ||
| #PyMySQL==1.0.2 | ||
| #psycopg2==2.9.1 | ||
| robotframework>=4.0.0 |
There was a problem hiding this comment.
Unless we require something from the new version of the RF, it's better to stick to lower version so more people can use library (for those who can't use RF 4.0 for some reason yet). WDYT @amochin ?
There was a problem hiding this comment.
Well, this requirements file doesn't define any dependencies for library users.
It's relevant for developers only - to extend the library code and run the tests.
Or so I was using this file before.
It's the pyproject.toml file, where are dependencies specified - for installing and using the library.
Currently it doesn't limit the RF version at all.
Regarding the library development, the requirements.txt - the current version in the master doesn't limit the RF version as well. However, the current tests use some things from later RF versions, so actually it makes sense to put an even higher limitations - like RF 5.0 maybe, would need to check it...
|
|
||
| Example db.cfg file | ||
| | [default] | ||
| | [alias] |
There was a problem hiding this comment.
Nice - thanks for that, we are keeping previous file configuration while allowing to use it for multiple aliased connections.
There was a problem hiding this comment.
Using docker compose for running multiple containers is a nice improvement for local test, we could consider including it.. The container params would need to be updated then, as the tests have already prepared port numbers, user credentials and db names. See the test/readme.md file in the master branch.
|
@nczita Since it looks you're either inactive or busy at the moment, I will update the PR for you. I will create new PR using your branch as a base (thanks for that you will remain author in the git history). Thanks again for contribution! |
|
Sorry, I have been very occupied lately, but I see that you have managed to take it over - with great results! |
3 participants
Support multiple DB connections.
Also: