[Feature] - Add API contract for asynchronous insight reaction PDF report generation#172
Open
InduwaraSMPN wants to merge 7 commits into
Open
[Feature] - Add API contract for asynchronous insight reaction PDF report generation#172InduwaraSMPN wants to merge 7 commits into
InduwaraSMPN wants to merge 7 commits into
Conversation
added 2 commits
May 27, 2026 09:04
…r-reactions-implementation
Contract-mirror only. The widget has zero runtime calls into the `insightReaction*` routes — this is the byte-identical SDK mirror per the shared-contracts rule. - `ReactionQuestionEntitySchema` + `ReactionAnswerEntitySchema` added. - `ReactionEntitySchema` drops `question`, gains `questions[]` and optional `drafted_questions`. - `ReactionResultEntitySchema` gains optional `answers[]`. - New `insightReactionTemplateConfirm` route. XOR refine on `insightReactionCreate`. `insightReactionContext` accepts `questions: string[]`. Type-check + code:check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ithub.com/Marketrix-ai/widget into user-reactions-implementation
…r-reactions-implementation
…r-reactions-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
insightReactionReportGenerateendpoint to the SDK contract (src/sdk/routes.ts).Functional Impact & Technical Reasoning:
POSTendpoint delegates PDF generation to a background task, immediately returning apendingstatus to the client.reaction-run/report-readyorreaction-run/report-failed) to retrieve the generated PDF URL.forceboolean flag, allowing clients to bypass any previously cached PDF reports and trigger a fresh render when necessary.Related issue
Closes #173
Test plan
npm run type-checkor equivalent).insightReactionReportGenerateaccept anid(coerced number) and an optionalforce(boolean), and return{ status: 'pending' }.Checklist
routes.ts,schema.ts,proto)