fix: remove stale install path from Nix fileset and unexport desktop target#9
Merged
rabsef-bicrym merged 5 commits intodevfrom Feb 26, 2026
Merged
Conversation
…target (pb: volt-b5c) - Remove ../install from nix/node_modules.nix fileset unions — path was inherited from upstream OpenCode and doesn't exist in Volt, causing Nix to refuse to evaluate the derivation at all (GitHub issue #3) - Remove desktop package definition and export from flake.nix — the desktop app has broken compile-time references post-fork and can't build; stop advertising it as a Nix target so users don't hit it - nix/desktop.nix and packages/desktop/ left intact for future revival Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- CI was trying to `nix build .#desktop` which no longer exists in flake.nix, causing the PR to fail deterministically Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rabsef-bicrym
force-pushed
the
fix/nix-fileset-stale-install
branch
from
7874566 to
2402dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Nix build failure reported in #3 and removes the unbuildable desktop package from Nix outputs.
Why
The Volt fork inherited a
../installfileset reference from upstream OpenCode, but the actual file was never carried over. Nix refuses to evaluate if a fileset path doesn't exist, sonix build .#voltcodefails immediately. Separately, thedesktopNix target can't compile (brokeninclude_str!reference to a missing install script), so exporting it just misleads users.Changes
../installfromnix/node_modules.nixfileset unionsdesktoppackage definition and export fromflake.nixnix/desktop.nixandpackages/desktop/left intact for future revivalTesting
bun typecheckpasses across all packagesCloses #3