[Marvell]Issue: On contiuous reboot once in a while CPU1 (secondary c…#3
Open
rajkumar38 wants to merge 1 commit intoMarvell-OpenNOS:masterfrom
rajkumar38:master
Open
[Marvell]Issue: On contiuous reboot once in a while CPU1 (secondary c…#3rajkumar38 wants to merge 1 commit intoMarvell-OpenNOS:masterfrom rajkumar38:master
rajkumar38 wants to merge 1 commit intoMarvell-OpenNOS:masterfrom
rajkumar38:master
Conversation
…pu) doesn't come online. The issue comes after migrating to Debian gcc 8.3.6, the issue was not seen till gcc7 Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
| mvebu_pmsu_set_cpu_boot_addr(hw_cpu, mvebu_cortex_a9_secondary_startup); | ||
| smp_wmb(); | ||
|
|
||
| + wait_for_completion_timeout(&cpu_wait, usecs_to_jiffies(10)); |
There was a problem hiding this comment.
Thanks @antony-rheneus for the quick review. I had discussion with @mickeyr@marvell.com and it is ok to raise PR with value 10.
There was a problem hiding this comment.
I'm OK with this value as I reviewed the assembly code and the optimization claim is very clear.
Also - the 10 micro-sec was confirmed by Nokia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pu) doesn't
come online. The issue comes after migrating to Debian gcc 8.3.6,
the issue was not seen till gcc7
Signed-off-by: Rajkumar Pennadam Ramamoorthy rpennadamram@marvell.com