Add basic internal data model #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be honest, we would never want to order Entries but only check if they are (in-)equal so removing the spaceship isn't to big of a deal. On top of that, gcc 11.4 complains about strings not being three-way-comparable in a constexpr manner.
For some reason, gcc 11.4 still complains, so let's remove that for now
Master92
force-pushed
the
feature/model
branch
from
74825d6 to
22d8e78
Compare
Owner
Author
|
There was a reason why I reverted the change to the conan install step.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until further work is done, all values are currently stored as
std::strings. I intent to introduce some kind of a variant data class but didn't have time to do so yet.After this is merged, I expect to be able to parse a simple ini-file.
Known limitations