V0.17.1 #45
Merged
V0.17.1 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ever be mounted due to rapid updates
ai-ui.ts * Add replaced nodes to removedNodes * Correct updating of appended to deal with re-ordered (out of order) nodes iterators.ts * Release ref to `prev` in filterMap on termination * Release ref to `current` in multi on termination when.ts * Move elementIsInDOM() and allSelectorsPresent() into containerAndSelectorsMounted() and use a closure to access the containing element * Reject in elementIsInDOM() if elt is *removed*
Next attempt will change the return type of nodes() to a sync iterator to prevent the need to update the appended array. Instead the result will flatten the `replacementNodes` see branch v0.15.6-sync-nodes
The removes the need to reference the returned value in a closure, in case is it updated. Instead, it is lazily walked on demand, including any updates. This appears to work fine (needs full tests). On examination, the remaining leak is when a node is removed and there is no subsequent iteration to unwind the references. This can happen, for example, when a node depends on a child it is expecting to receieve events, but the child is removed and so the container (with an implicit reference to teh child) never receives another input event from the removed child, leaving it in the async iteration state forever, having never called ai.return() (or throw)
...by checking when a DOM node is removed if any associated async iterator should be terminated. This is acheieved by weakly associating the termination function with the node, which is invoked by the mutationTracker.
* Fold ai-ui-style tags into one per document * Re-implement legacy onRemovedFromDOM as tracked removal handler * Log exceptions in removal handlers * Ensure correct `this` in isAncestral (debug only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.