Fix White rectangle when disabling Calendar #3935
Merged
+27
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut CalendarDayButton
corvinsz
added
the
visual breaking change
Member
|
One small thing, I think we want to also change the opacity on the year text as well. |
Member
Author
|
Done! |
This was referenced Oct 6, 2025
Merged
This was referenced Oct 20, 2025
This was referenced Nov 1, 2025
This was referenced Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3932
Visual breaking change!
The
IsEnabledof all childs of the Calendar was already inherited correctly.I added a visual state to grey out the
MaterialDesignCalendarDayButtonto indicate the disabled state.I removed the rectangle (
PART_DisabledVisual) which was previously overlaying the Calendar when it was disabled.Notes
The MD2 & 3 specs do not specify looks for a disabled calendar, but I find the current behavior very unsuitable.
When no official spec is given, my next best bet is always to get inspired by other UI libraries.
In React MUI it's done like one would expect, simply grey out all of the Buttons of the Calendar.
https://mui.com/x/react-date-pickers/date-calendar/#form-props
Before
After