Radians instead of degrees in np.sin() and np.cos()?

[lifangda01]

valis/valis/serial_rigid.py

Lines 494 to 496 in aa8368c

	# Get dimensions if images were rotated 45 degrees or 90 degrees
	max_new_w = out_w*np.cos(45) + out_h*np.sin(45)
	max_new_h = out_w*np.sin(45) + out_h*np.cos(45)

[cdgatenbee]

Hi @lifangda01,
Yes, you're right, those should be in radians. I've gone through and verified this is the only place where degrees were being passed to np.cos or np.sin. In this case it was only being used to determine the shape of a padded image that eventually gets cropped, so it shouldn't affect the accuracy of the registration. I appreciate you bring this to my attention, and I'll have it fixed in the next update.

Best,
-Chandler

[lifangda01]

Thank you for your response and the great work!