Skip to content

Conversation

@rocky
Copy link
Member

@rocky rocky commented Dec 13, 2024

Fixes #1221

Before change:

$ mathics -e 'Table[Random[], {6}]'
{{0.}, {0.}, {4.94066×10^-324}, {0.}, {0.}, {0.}}

After change:

mathics -e 'Table[Random[], {6}]'
{0.0480615, 0.0366987, 0.0705173, 0.283725, 0.84478, 0.138017}

Rule rewrites before change:

In[4]:= TraceEvaluation[Random[]]
  Evaluating: System`Random[]
    Evaluating: System`Random
    -> System`RandomReal[0, 1]
    Evaluating: System`RandomReal
    -> System`RandomReal[System`List[0, 0], 1]
    Evaluating: System`RandomReal
    Evaluating: System`List[0, 0]
    -> System`RandomReal[System`List[0, 0], System`List[1]]
    Evaluating: System`RandomReal
    Evaluating: System`List[0, 0]
    Evaluating: System`List[1]
    -> {5e-324}
Out[4]= {4.94066×10^-324}


@rocky rocky requested a review from mmatera December 13, 2024 02:08
@rocky
Copy link
Member Author

rocky commented Dec 13, 2024

kkpo4553@cde2b60 seems better. Changes incorporated and improved.

@rocky rocky marked this pull request as draft December 13, 2024 02:51
@rocky rocky marked this pull request as ready for review December 13, 2024 12:11
@mmatera
Copy link
Contributor

mmatera commented Dec 13, 2024

LGTM

@rocky rocky merged commit 0af3ccc into master Dec 13, 2024
13 checks passed
@rocky rocky deleted the improve-Random-randomness branch December 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random[] is not random

3 participants