use named function expressions instead of arguments.callee#2
Open
ianwremmel wants to merge 2 commits intoMathieuTurcotte:masterfrom
Open
use named function expressions instead of arguments.callee#2ianwremmel wants to merge 2 commits intoMathieuTurcotte:masterfrom
ianwremmel wants to merge 2 commits intoMathieuTurcotte:masterfrom
Conversation
lib/checks.js
Outdated
Owner
There was a problem hiding this comment.
You don't want to start the stack trace from the typeCheck function, but from the closure returned from calling the function.
Author
There was a problem hiding this comment.
ah, right. glad you caught that.
Author
|
Well, my day job got a little distracting, but I've finally updated this PR. Looks like there's a problem with one of the test dependencies in node 0.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments/callee, arguments.callee has been deprecated and can't be optimized at runtime. Named function expressions should get around this problem.