Use inherits and format-util for smaller bundle size#5
Open
nolanlawson wants to merge 1 commit intoMathieuTurcotte:masterfrom
Open
Use inherits and format-util for smaller bundle size#5nolanlawson wants to merge 1 commit intoMathieuTurcotte:masterfrom
nolanlawson wants to merge 1 commit intoMathieuTurcotte:masterfrom
Conversation
Author
|
Looks like the build is failing because the tested versions of Node (0.8 and 0.10) are too old for npm to support. |
|
Any plans for merging this !? |
arun3528
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require('util')takes up quite a bit of space when used in the browser. These modules (inheritsandformat-util) use the standardrequire('util')in Node, but have smaller implementations when built for the browser.So this PR saves 7.67kB or 72.6% of the total size.
I measured the size using
browserify . | uglifyjs -mc | wc -c.