Re-enable disabled tests

package.json

@@ -132,7 +132,7 @@
     "nexpect": "^0.6.0",
     "node-gyp-build": "^4.4.0",
     "nodemon": "^3.0.1",
-    "polykey": "^1.2.1-alpha.45",
+    "polykey": "^1.2.1-alpha.46",
     "prettier": "^3.0.0",
     "shelljs": "^0.8.5",
     "shx": "^0.3.4",

src/errors.ts

@@ -66,7 +66,7 @@ class ErrorPolykeyCLIUnhandledRejection<T> extends ErrorPolykeyCLI<T> {
 }
 
 /**
- * Asychronous deadlocks is a logic error.
+ * Asynchronous deadlocks is a logic error.
  * If these exceptions occur, there is a bug.
  */
 class ErrorPolykeyCLIAsynchronousDeadlock<T> extends ErrorPolykeyCLI<T> {

src/nodes/CommandFind.ts

@@ -51,14 +51,15 @@ class CommandFind extends CommandPolykey {
           },
           logger: this.logger.getChild(PolykeyClient.name),
         });
-        const result = {
+        const result: {
+          success: boolean;
+          message: string;
+          id: string;
+          address?: { host: Host | Hostname; port: Port };
+        } = {
           success: false,
           message: '',
           id: '',
-          address: {
-            host: '',
-            port: 0,
-          },
         };
         let foundAddress:
           | {
@@ -111,7 +112,7 @@ class CommandFind extends CommandPolykey {
           });
         }
         process.stdout.write(outputFormatted);
-        // Like ping it should error when failing to find node for automation reasons.
+        // Like ping, it should error when failing to find node for automation reasons.
         if (!result.success) {
           throw new errors.ErrorPolykeyCLINodeFindFailed(result.message);
         }

src/nodes/CommandPing.ts

@@ -48,7 +48,7 @@ class CommandPing extends CommandPolykey {
           },
           logger: this.logger.getChild(PolykeyClient.name),
         });
-        let error;
+        let error: any;
         const statusMessage = await binUtils.retryAuthentication(
           (auth) =>
             pkClient.rpcClient.methods.nodesPing({

src/secrets/CommandEdit.ts

@@ -87,7 +87,7 @@ class CommandEdit extends CommandPolykey {
           secretName: secretPath[1],
           secretContent: content.toString('binary'),
         });
-        await this.fs.promises.rmdir(tmpDir, { recursive: true });
+        await this.fs.promises.rm(tmpDir, { recursive: true, force: true });
         // Windows
         // TODO: complete windows impl
       } finally {

src/types.ts

@@ -18,7 +18,7 @@ type AgentStatusLiveData = Omit<StatusLive['data'], 'nodeId'> & {
 };
 
 /**
- * PolykeyAgent Starting Input when Backgrounded
+ * PolykeyAgent Starting Input when backgrounded
  * When using advanced serialization, rich structures like
  * Map, Set and more can be passed over IPC
  * However traditional classes cannot be

src/utils/ExitHandlers.ts

@@ -5,8 +5,8 @@ import * as errors from '../errors';
 
 class ExitHandlers {
   /**
-   * Mutate this array to control handlers
-   * Handlers will be executed in reverse order
+   * Mutate this array to control handlers.
+   * Handlers will be executed in reverse order.
    */
   public handlers: Array<(signal?: NodeJS.Signals) => Promise<void>>;
   protected _exiting: boolean = false;

src/utils/utils.ts

@@ -242,7 +242,7 @@ function outputFormatterList(items: Array<string>): string {
  * @param options
  * @param options.columns - Can either be an `Array<string>` or `Record<string, number>`.
  * If it is `Record<string, number>`, the `number` values will be used as the initial padding lengths.
- * The object is also mutated if any cells exceed the inital padding lengths.
+ * The object is also mutated if any cells exceed the initial padding lengths.
  * This parameter can also be supplied to filter the columns that will be displayed.
  * @param options.includeHeaders - Defaults to `True`
  * @param options.includeRowCount - Defaults to `False`.

tests/TestProvider.ts

@@ -82,13 +82,13 @@ class TestProvider extends Provider {
     authIdentityId: IdentityId,
     identityId: IdentityId,
   ): Promise<IdentityData | undefined> {
-    let providerToken = await this.getToken(authIdentityId);
+    const providerToken = await this.getToken(authIdentityId);
     if (!providerToken) {
       throw new identitiesErrors.ErrorProviderUnauthenticated(
         `${authIdentityId} has not been authenticated`,
       );
     }
-    providerToken = await this.checkToken(providerToken, authIdentityId);
+    await this.checkToken(providerToken, authIdentityId);
     const user = this.users[identityId];
     if (!user) {
       return;
@@ -106,13 +106,13 @@ class TestProvider extends Provider {
     authIdentityId: IdentityId,
     searchTerms: Array<string> = [],
   ): AsyncGenerator<IdentityData> {
-    let providerToken = await this.getToken(authIdentityId);
+    const providerToken = await this.getToken(authIdentityId);
     if (!providerToken) {
       throw new identitiesErrors.ErrorProviderUnauthenticated(
         `${authIdentityId} has not been authenticated`,
       );
     }
-    providerToken = await this.checkToken(providerToken, authIdentityId);
+    await this.checkToken(providerToken, authIdentityId);
     for (const [k, v] of Object.entries(this.users) as Array<
       [
         IdentityId,
@@ -152,8 +152,8 @@ class TestProvider extends Provider {
     await this.checkToken(providerToken, authIdentityId);
     const linkId = this.linkIdCounter.toString() as ProviderIdentityClaimId;
     this.linkIdCounter++;
-    const identityClainEncoded = tokenUtils.generateSignedToken(identityClaim);
-    this.links[linkId] = JSON.stringify(identityClainEncoded);
+    const identityClaimEncoded = tokenUtils.generateSignedToken(identityClaim);
+    this.links[linkId] = JSON.stringify(identityClaimEncoded);
     this.userLinks[authIdentityId] = this.userLinks[authIdentityId]
       ? this.userLinks[authIdentityId]
       : [];

tests/agent/start.test.ts

@@ -265,8 +265,8 @@ describe('start', () => {
       ]);
       // These will be the last line of STDERR
       // The readline library will automatically trim off newlines
-      let stdErrLine1;
-      let stdErrLine2;
+      let stdErrLine1: string;
+      let stdErrLine2: string;
       const rlErr1 = readline.createInterface(agentProcess1.stderr!);
       const rlErr2 = readline.createInterface(agentProcess2.stderr!);
       const agentStartedProm1 = promise<[number, string]>();
@@ -310,8 +310,7 @@ describe('start', () => {
     },
     globalThis.defaultTimeout * 2,
   );
-  // FIXME: disabled for now, both are succeeding when 1 should fail
-  test.skip(
+  test(
     'concurrent with bootstrap results in 1 success',
     async () => {
       const password = 'abc123';
@@ -360,8 +359,8 @@ describe('start', () => {
       ]);
       // These will be the last line of STDERR
       // The readline library will automatically trim off newlines
-      let stdErrLine1;
-      let stdErrLine2;
+      let stdErrLine1: string;
+      let stdErrLine2: string;
       const rlErr1 = readline.createInterface(agentProcess.stderr!);
       const rlErr2 = readline.createInterface(bootstrapProcess.stderr!);
       const agentStartedProm1 = promise<[number, string]>();
@@ -679,7 +678,7 @@ describe('start', () => {
       );
       const statusInfo2 = await status.waitFor('LIVE');
       expect(statusInfo2.status).toBe('LIVE');
-      // Node Id hasn't changed
+      // Node ID hasn't changed
       expect(statusInfo1.data.nodeId).toStrictEqual(statusInfo2.data.nodeId);
       agentProcess2.kill('SIGTERM');
       await testUtils.processExit(agentProcess2);
@@ -874,7 +873,7 @@ describe('start', () => {
     globalThis.defaultTimeout * 2,
   );
   describe('start with global agent', () => {
-    let agentDataDir;
+    let agentDataDir: string;
     let agent1Status: StatusLive;
     let agent1Close: () => Promise<void>;
     let agent2Status: StatusLive;

tests/agent/status.test.ts

@@ -63,7 +63,7 @@ describe('status', () => {
         logger,
       );
       await status.waitFor('STARTING');
-      let exitCode, stdout;
+      let exitCode: number, stdout: string;
       ({ exitCode, stdout } = await testUtils.pkExec(
         ['agent', 'status', '--format', 'json'],
         {
@@ -132,9 +132,9 @@ describe('status', () => {
     });
   });
   describe('status with global agent', () => {
-    let agentDir;
-    let agentPassword;
-    let agentClose;
+    let agentDir: string;
+    let agentPassword: string;
+    let agentClose: () => Promise<void>;
     beforeEach(async () => {
       ({ agentDir, agentPassword, agentClose } =
         await testUtils.setupTestAgent(logger));

tests/agent/unlock.test.ts

@@ -9,9 +9,9 @@ describe('unlock', () => {
   const logger = new Logger('unlock test', LogLevel.WARN, [
     new StreamHandler(),
   ]);
-  let agentDir;
-  let agentPassword;
-  let agentClose;
+  let agentDir: string;
+  let agentPassword: string;
+  let agentClose: () => Promise<void>;
   beforeEach(async () => {
     ({ agentDir, agentPassword, agentClose } =
       await testUtils.setupTestAgent(logger));
@@ -27,7 +27,7 @@ describe('unlock', () => {
       logger,
       fresh: true,
     });
-    let exitCode, stdout;
+    let exitCode: number, stdout: string;
     ({ exitCode } = await testUtils.pkExec(['agent', 'unlock'], {
       env: {
         PK_NODE_PATH: agentDir,