getClosestGlobalNodes, findNode error fix#402
Merged
tegefaulkes merged 1 commit intostagingfrom Jul 13, 2022
Merged
Conversation
12 tasks
5 tasks
Member
|
@emmacasolin requires rebase on master. Also consult with @tegefaulkes and the situation and compare with what's going on AWS. Make sure you're able to run |
Member
|
Rename this PR more appropriately targeting what is being done here. |
Member
|
Regarding the worker manager fix. I want to put that off for moment. Can you separate the PRs... cause I the worker manager deserves more thought. |
tegefaulkes
force-pushed
the
feature-bug_fixes
branch
from
bf1ce12 to
9375e75
Compare
tegefaulkes
changed the title
getClosestGlobalNodes, findNode error fix
Contributor
Author
|
This PR was split into two. The |
…deGraphEmptyDatabase` with empty network `getClosestGlobalNodes` was throwing `ErrorNodeGraphEmptyDatabase` when it failed to get new nodes during the search process. Now it just returns undefined as expected. Related #398
tegefaulkes
force-pushed
the
feature-bug_fixes
branch
from
9375e75 to
8990017
Compare
Contributor
Author
|
This should be good to merge now. @CMCDragonkai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses...
#398 Was a problem with
NodeConnectionManager.getClosestGlobalNodesthrowing an error if thenodeGraphwas empty. This shouldn't happen in usual operation unless said node is a seed node with no nodes in the network. Here it's not strictly an error since having no nodes in the graph just means we can't find any other nodes or the target node for that matter.getClosestGlobalNodesshould've just returned undefined.Issues Fixed
ErrorNodeGraphEmptyDatabase#398Final checklist