Improve search iteration for Github identity search#579
Merged
CMCDragonkai merged 5 commits intostagingfrom Oct 19, 2023
Merged
Improve search iteration for Github identity search#579CMCDragonkai merged 5 commits intostagingfrom
CMCDragonkai merged 5 commits intostagingfrom
Conversation
amydevs
force-pushed
the
feature-improve-githubProvider
branch
from
ebb5842 to
224aea2
Compare
Member
|
Needs to be squashed and commentary resolved. |
Closed
amydevs
force-pushed
the
feature-improve-githubProvider
branch
from
9372c8c to
5dfd7e3
Compare
feat: Promise based follower and following resolve if withing rate limit fix: hopefully improve search time
…nnectedIdentityDatas`
amydevs
force-pushed
the
feature-improve-githubProvider
branch
from
5dfd7e3 to
6137948
Compare
…aginate [ci-skip]
amydevs
force-pushed
the
feature-improve-githubProvider
branch
from
f09207f to
0a5899a
Compare
Member
|
It's now instant, great! Originally it was 2 requests, one to the page, another to get the user detail for each user. Now it is just 1 request to the page, which also contains the additional information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR aims to improve github identity search since it was very slow iterating over every user followed / following. Now it does a rate search and Promise.all if current rate limit allows it.
Issues Fixed
Tasks
Final checklist