PKClient needs to use WebSocketClient and RPCClient in the start/stop procedure

[CMCDragonkai]

Description

The PKClient needs to use WS and RPC in the start/stop so that we can start and stop the PK client to any given client service, while also destroying is for destroying the session state.

Issues Fixed

• Related Integration of - WebSocket encapsulation in PolykeyClient and alternation of options in PolykeyAgent and Client. Polykey-CLI#42 (comment)

Tasks

• 1. Moved WebSocketClient and RPCClient into start/stop
• 2. Exposed PolykeyClient.nodeId
• 3. PolykeyClient.start now takes a subset of the creation parameters, and you can stop and start a connection to different client service

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[ghost]

👇 Click on the image for a new way to code review

Legend

[CMCDragonkai]

Note that options are never saved since they are always re-defaulted.

So when you create, stop, start. On the start call you have pass back whatever options you wanted.

UX wise it might be unexpected. We could solve this in the future by saving the options on creation, and then having start default to the options set on creation if they exist, otherwise the default config. It would be a good idea to then extend mergeObjects to be multi-arity.