Adding cancellation to background handlers to prevent agent from being held open#872
Merged
aryanjassal merged 2 commits intostagingfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
|
There were some weird issues happening when I attempt to link Polykey's dist directory to Polykey CLI's |
tegefaulkes
reviewed
Feb 11, 2025
Contributor
tegefaulkes
left a comment
There was a problem hiding this comment.
You've added @timedCancellable(true) all over the place. Keep in mind that without a default timeout provided then it will default to infinite timeout. In most cases we don't want this. Check what the existing @timedCancellable usage for each file is doing.
chore: resolved failing Discovery tests chore: resolved failing Nodes tests
1df6f65 to
584af7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Often, some background task handlers hold the agent open when we are trying to shutdown. The only solution is to send a SIGKILL to the process to forcefully shut it down. This should not happen.
Issues Fixed
polykey agent stopcommand not terminating properly Polykey-CLI#185 (FIX ENG-322)Tasks
Discovery.discoverVertexHandlerNodeManager.syncNodeGraphHandlerNodeManager.checkConnectionsHandlerNodeManager.refreshBucketHandlerFinal checklist