Skip to content

HTTP 1.1 Basic Authentication Support#30

Merged
amydevs merged 3 commits intostagingfrom
feature-basic-authentication
Nov 23, 2023
Merged

HTTP 1.1 Basic Authentication Support#30
amydevs merged 3 commits intostagingfrom
feature-basic-authentication

Conversation

@amydevs
Copy link
Copy Markdown
Contributor

@amydevs amydevs commented Oct 23, 2023

Description

This PR allows users to process the HTTP headers of incoming connections in verifyCallback and provide headers in the WebSocketConfig to facilitate HTTP 1.1 Basic Authentication.

Furthermore, the user is able to provide headers on the config parameter of both WebSocketClient and WebSocketServer.

Issues Fixed

Tasks

  • 1. Pass headers into TLSVerifyCallback
  • 2. Allow user to pass headers into config

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@amydevs amydevs merged commit e9b514c into staging Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Enable Pre-Connection Authentication using HTTP Authentication Headers

1 participant