feature: isomorphic WebSocket support

[amydevs]

Description

Allows WebSocketClient and WebSocketConnection to work with the browser WebSocket implementation.

To note some discoveries:

• We need to polyfill Buffer
• We need to polyfill perf_hooks with the browser performance API to work with browsers.

Issues Fixed

• Fixes Isomorphic js-ws #6

Tasks

• 1. Make WebSocketClient work with browser WebSockets
• 2. Make WebSocketConnection work with browser WebSockets
• 3. Write tests to mock a browser WebSocket using ws library.
• 4. End to end test using browser React bundle.

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[amydevs]

webpack/webpack#13585

How i got perf_hooks working ^

[CMCDragonkai]

Why is this?

[amydevs]

Because the cause can either be an Error or an event. It doesn't rlly matter what this value is, as it's just set as the cause of the thrown error

[tegefaulkes]

Using any type tends to be pretty hacky. Generally if the type isn't well defined and it doesn't really matter then unknown can be used instead of any.

While any can be anything and assigned to anything. unknown could be anything but can't be assigned to anything else. So it's safer to use. https://stackoverflow.com/questions/51439843/unknown-vs-any

[CMCDragonkai]

webpack/webpack#13585

How i got perf_hooks working ^

That's a downstream thing right? Not something this repo would do. Because it produces an npm package.

However you can update the readme to explain too.

[amydevs]

@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.

[CMCDragonkai]

@CMCDragonkai yes, it would be something that downstream would have to do. Although, we can automatically apply the polyfill in js-timer directly if we want to.

No we shouldn't preemptively polyfill. So readme it is.

Did you read my review?