Skip to content

shade entitylib & remove Paper-weight#61

Closed
Dominilk01 wants to merge 5 commits intoMatt-MX:mainfrom
Dominilk01:main
Closed

shade entitylib & remove Paper-weight#61
Dominilk01 wants to merge 5 commits intoMatt-MX:mainfrom
Dominilk01:main

Conversation

@Dominilk01
Copy link
Copy Markdown
Contributor

relocation of entitylib for devs that will use this as API it awoid LinkageError

@Matt-MX
Copy link
Copy Markdown
Owner

Matt-MX commented Mar 10, 2025

@Dominilk01
Thanks for the PR!
Switching to paper api is probably a good idea, since we're not using any features that require paperweight.

Can you please delete the commented-out paperweight dependancy and remove it from the plugins list.

I'll accept this into a branch just so I can test it first!

@Dominilk01
Copy link
Copy Markdown
Contributor Author

For me all work fine
bdw don't need to make a new branch to test you can git clone https://github.com/Dominilk01/DisplayNameTags-FORK.git

Copy link
Copy Markdown
Contributor Author

@Dominilk01 Dominilk01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea im stupid i forget to push this
also added #62 with other updates

My test (i use custom trait and sneak trait)
https://github.com/user-attachments/assets/ac6c8600-9d9a-485b-bf59-91da96edc6ec

@Dominilk01 Dominilk01 changed the title shade entitylib shade entitylib & remove Paper-weight Mar 22, 2025
@Dominilk01 Dominilk01 force-pushed the main branch 2 times, most recently from a17da5e to c3e9f43 Compare March 23, 2025 00:15
@Bram1903
Copy link
Copy Markdown
Collaborator

Bram1903 commented Jun 2, 2025

Hey,

Thank you for this PR! However, this has now been resolved in #78 together with some other issues. Please feel free to open any other PR in the future, and they will get reviewed much faster. I'll terrorize Matt the next time ;-)

Kind regards,
Bram

@Bram1903 Bram1903 closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants