Skip to content

Finalize, restrict visibility and typehint#114

Merged
VincentLanglet merged 2 commits intoMattKetmo:masterfrom
VincentLanglet:bcBreak
Jan 25, 2026
Merged

Finalize, restrict visibility and typehint#114
VincentLanglet merged 2 commits intoMattKetmo:masterfrom
VincentLanglet:bcBreak

Conversation

@VincentLanglet
Copy link
Collaborator

No description provided.

@VincentLanglet VincentLanglet marked this pull request as ready for review December 16, 2025 15:55
@VincentLanglet
Copy link
Collaborator Author

Since we have to do a BC-break in order to add Symfony 8 support (with the contraint changes and the validator typehint), I think it's the best moment to do all the BC break and a new major.

So we can

  • add typehint every where
  • add final to classes to avoid futur BC break

Do you agree with this PR @MattKetmo

@VincentLanglet
Copy link
Collaborator Author

Friendly ping @MattKetmo, do you agree with a new major ?

@MattKetmo
Copy link
Owner

Sure, no problem.

@VincentLanglet VincentLanglet merged commit f8d405b into MattKetmo:master Jan 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants