fix: handle Joern command timeout output safely#94
Merged
Conversation
Change the Joern process timeout path to terminate the process and return the timeout diagnostic without reading stdout after the process stream may already be closed on Linux. Affected component: ProcessJoernCommandExecutor in the Joern adapter support package. Bug fixed: Linux CI failed in JoernOutputParserTest.processExecutorReportsTimeouts with an IOException: Stream closed before SonarCloud could run. Features introduced: none. Refactoring or architecture changes: none. Breaking changes: none. Tests executed: WSL ./gradlew test --tests de.burger.forensics.adaptersupport.joern.JoernOutputParserTest.processExecutorReportsTimeouts --console=plain --stacktrace; WSL ./gradlew clean test jacocoTestReport jacocoTestCoverageVerification checkPackageCoverage --console=plain --stacktrace; Windows .\\gradlew.bat test --tests de.burger.forensics.adaptersupport.joern.JoernOutputParserTest.processExecutorReportsTimeouts --console=plain --stacktrace.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
wsl.exe bash -lc "cd /mnt/d/Projects/forensics_tracing && ./gradlew test --tests de.burger.forensics.adaptersupport.joern.JoernOutputParserTest.processExecutorReportsTimeouts --console=plain --stacktrace"wsl.exe bash -lc "cd /mnt/d/Projects/forensics_tracing && ./gradlew clean test jacocoTestReport jacocoTestCoverageVerification checkPackageCoverage --console=plain --stacktrace"./gradlew.bat test --tests de.burger.forensics.adaptersupport.joern.JoernOutputParserTest.processExecutorReportsTimeouts --console=plain --stacktrace