Expand unit coverage for transient cache behavior and adapter safety guards#5
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
MaximillianGroup
May 26, 2026 04:45
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands PHPUnit unit coverage around two core safety/isolation areas in StarCache: (1) transient caching behavior across site vs network scopes and (2) adapter guardrails for “write-once” semantics and dangerous flush blocking.
Changes:
- Added unit tests for
StarTransientCacheset/get/delete behavior, including per-blog isolation and network-transient sharing semantics. - Added unit tests for
StarCacheAdapter::add()(WP fallback, no-overwrite) andStarCacheAdapter::flush()(blocked unless explicitly enabled). - Hardened test isolation by resetting the in-memory transient shim state in
setUp().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage in areas that were untested despite being core cache-safety and data-isolation paths. It adds focused unit tests around transient cache lifecycle behavior and adapter guardrails.
Coverage expansion: transient cache lifecycle + isolation
StarTransientCachesite-scoped set/get/delete behavior.Coverage expansion: adapter safety semantics
StarCacheAdapter::add()in WP fallback mode to confirm write-once behavior (no overwrite when key exists).StarCacheAdapter::flush()to ensure dangerous flush is blocked unless explicitly enabled.Test fixture hardening
setUp()to prevent cross-test contamination for newly covered paths.