Define write off transaction dto #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvasco
approved these changes
Nov 13, 2025
avesk
reviewed
Nov 13, 2025
| "receivedPayment.created": lambda _id, _type, attributes, relationships: | ||
| ReceivedPaymentCreatedEvent.from_json_api(_id, _type, attributes, relationships), | ||
|
|
||
| "writeOffTransaction": lambda _id, _type, attributes, relationships: |
Collaborator
There was a problem hiding this comment.
Are these not getting sent as transaction.created events?
Collaborator
Author
There was a problem hiding this comment.
The codec resolves any unlisted types as a generic RawUnitObject. We should still be processing it appropriately but I'll add a test in our app to make sure.
Collaborator
There was a problem hiding this comment.
Okay, so what was happening here? Was there an error?
Collaborator
Author
There was a problem hiding this comment.
No, I'm just adding the DTO to be used in some tests mocking the transaction.
avesk
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.