Skip to content

ENG-2874: add date filters to list events #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelvasco merged 2 commits into from
Dec 1, 2025
Merged

ENG-2874: add date filters to list events #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
177f6e0
feat: add date filters to the list events endpoint
samuelvasco Nov 28, 2025
4db852a
fix: offset type
samuelvasco Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion unit/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,13 +917,26 @@ def from_json_api(_id, _type, attributes, relationships):


class ListEventParams(UnitParams):
def __init__(self, limit: int = 100, offset: int = 0, type: Optional[List[str]] = None):
def __init__(
self,
limit: int = 100,
offset: int = 0,
type: Optional[str] = None,
since: Optional[str] = None,
until: Optional[str] = None,
):
self.limit = limit
self.offset = offset
self.type = type
self.since = since
self.until = until

def to_dict(self) -> Dict:
parameters = {"page[limit]": self.limit, "page[offset]": self.offset}
if self.type:
parameters["filter[type][]"] = self.type
if self.since:
parameters["filter[since]"] = self.since
if self.until:
parameters["filter[until]"] = self.until
return parameters
Loading