-
Notifications
You must be signed in to change notification settings - Fork 42
Speedup jar package scanning #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can be used to skip assets/ and data/ folders for MC mods.
marchermans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principal this is fine. But I have one thing to nitpick
|
Just out of curiosity: Can you run the JarModuleFinderBenchmark? I know the set of jars is not optimal for testing the speedup of parallel scanning, but I think they still provide some value. Overall, nice work! |
|
Default jar metadata implementations should be changed too to benefit from parallelization, that might save over 1s of startup in some cases based on some profiles from ATM8. |

I noted that building the module references was quite slow on the FC pack, so I propose these two simple changes:
assetsanddatamod files for JARs.ModuleReferences in parallel because why not.Performance numbers on the FC pack (single run per line so not super precise but VisualVM confirms the observations):