This repository was archived by the owner on Jul 24, 2019. It is now read-only.
bundle dependencies#585
Merged
Merged
Conversation
Bundling the dependencies ensures that they are always present when npm runs a package's lifecycle scripts. This is necessary to get any sort of consistency in behaviour when using dependencies in install scripts because the installation order in npm@2 is non-deterministic and that is the version of npm that ships with the current LTS releases of Node. This should address Medium#581, Medium#580, Medium#578, Medium#553, Medium#584 May also help with Medium#302, Medium#556, Medium#555, which aren't clear what their root causes are due to lack of detail.
Contributor
Author
|
As a PoC/test, this was published as bundled-phantomjs-prebuilt which seemed to clear up the problem for me in all the environments I tested in that were previously failing (#580 - node 0.10, 0.12, 4 on Linux). |
|
Works for me as well. I was able to install with Docker. |
Contributor
|
sure, happy to try it and see if it helps |
Contributor
Author
|
@nicks thanks for the quick turnaround, really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundling the dependencies ensures that they are always present when npm
runs a package's lifecycle scripts. This is necessary to get any sort of
consistency in behaviour when using dependencies in install scripts
because the installation order in npm@2 is non-deterministic and that is
the version of npm that ships with the current LTS releases of Node.
This should address #581, #580, #578, #553, #584
May also help with #302, #556, #555, which aren't clear what their root
causes are due to lack of detail.