Feature vector logging #7
Merged
Merged
Conversation
For testing purposes, will implement torque getting. This is viable for MVP
rskew
approved these changes
Sep 24, 2018
Collaborator
rskew
left a comment
There was a problem hiding this comment.
Approve pending getting it working with VTS
| /** TODO - rewrite this section to be more elegant and correct*/ | ||
|
|
||
| Vector3D ang_accel = satellite.getStates().getCurrentState().getAttitude().getRotationAcceleration(); | ||
| double torqueX = ang_accel.getX()/satellite.getAssembly().getBody().getInertiaMatrix()[0][0]; |
Collaborator
There was a problem hiding this comment.
Only works for diagonal inertia matrices. Maybe worth a specific comment.
Author
There was a problem hiding this comment.
I'll add that then hit merge :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds various vectors to logging so that they can be modeled in VTS