Skip to content

ci: Wait 2 minutes to start second tests attempt instead of 1 hour#194

Closed
edgarrmondragon wants to merge 1 commit intomainfrom
fix/tests-2nd-run-start-1-hour
Closed

ci: Wait 2 minutes to start second tests attempt instead of 1 hour#194
edgarrmondragon wants to merge 1 commit intomainfrom
fix/tests-2nd-run-start-1-hour

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Member

@edgarrmondragon edgarrmondragon commented Apr 21, 2023

Currently it's waiting a whole hour to start

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@laurentS
Copy link
Copy Markdown
Contributor

laurentS commented May 3, 2023

@edgarrmondragon I guess the test failure above sort of confirms that we need more than 2 min wait time between CI attempts. The 1h wait time was added to ensure github rate limits are reset (their limits are N reqs/hour). We've been agonising over this, but haven't really figured out the solution.

The best option is probably making request caching work, but we haven't managed to do this. See #60 and #169

@edgarrmondragon
Copy link
Copy Markdown
Member Author

@edgarrmondragon I guess the test failure above sort of confirms that we need more than 2 min wait time between CI attempts. The 1h wait time was added to ensure github rate limits are reset (their limits are N reqs/hour). We've been agonising over this, but haven't really figured out the solution.

The best option is probably making request caching work, but we haven't managed to do this. See #60 and #169

@laurentS I see. Thanks for the explanation, this was meant to support testing #193 but I think we've identified the problem in that PR.

@edgarrmondragon edgarrmondragon deleted the fix/tests-2nd-run-start-1-hour branch January 26, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants