Fixes for compatibility with latest Catlab/ACSets#15
Merged
thevolatilebit merged 6 commits intoMerck:ref-agentsfrom Oct 10, 2023
Merged
Fixes for compatibility with latest Catlab/ACSets#15thevolatilebit merged 6 commits intoMerck:ref-agentsfrom
thevolatilebit merged 6 commits intoMerck:ref-agentsfrom
Conversation
Collaborator
Author
|
@thevolatilebit the tests are failing because |
thevolatilebit
approved these changes
Oct 10, 2023
Collaborator
thevolatilebit
left a comment
thevolatilebit
left a comment
There was a problem hiding this comment.
Thank you, it is much better that we use only ACSets now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @thevolatilebit I updated the code to be compatible with the latest version of Catlab/ACSets packages. Now the example in #14 runs on those latest versions.
Please note I also had to change some code in
src/solvers.jl, the type oftrans_[:transHash]was a string but the key type ofterminated_allwas symbol so I needed to do the string->symbol conversion. There is probably a better way to do this deeper in the code but this was the minimal change to get the example in your PR to work.