Skip to content

Update to dbsync_deamon#104

Merged
wonder-sk merged 11 commits intomasterfrom
argparse
Mar 26, 2023
Merged

Update to dbsync_deamon#104
wonder-sk merged 11 commits intomasterfrom
argparse

Conversation

@JanCaha
Copy link
Collaborator

@JanCaha JanCaha commented Mar 24, 2023

Fixes #97
Fixes #94

  • Allows dbsync_deamon.py to be run in single run mode, where only one run is performed.
  • dbsync.py does not run as a CLI anymore
  • better handling of exceptions (with exit(1))

@JanCaha JanCaha requested a review from wonder-sk March 24, 2023 15:45
Copy link
Contributor

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also solve #91 if dbsync.py will not be runned directly (the ability to run it could be also removed as part of this PR).

yeah feel free to remove the option to run dbsync.py directly as a CLI tool

Should the error also end python using exit(1), so it does not end as success?

That would make sense to me. Just in case of pull/push within db sync daemon, I would not exit, as it could be just a temporary network/server issue which should not stop the daemon altogether...

@JanCaha
Copy link
Collaborator Author

JanCaha commented Mar 24, 2023

  • removed ability to run dbsync.py as CLI tool
  • will exit with error code unless in while loop
  • also fixed Default config yaml throws a configuration error #94 - now skip_tables can be empty, empty list, list or string and the get_ignored_tables() will return correct representation - this includes couple of new test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to use custom config file Default config yaml throws a configuration error

2 participants