Conversation
Merged
wonder-sk
approved these changes
May 10, 2023
Contributor
wonder-sk
left a comment
wonder-sk
left a comment
There was a problem hiding this comment.
For a follow up PR:
- do not create
LOGGERglobal object - simply use the root logging object everywhere, simplifying the code (just calling e.g.logging.info(...)orlogging.error(...)) - set up root logger with https://docs.python.org/3/library/logging.handlers.html#logging.StreamHandler so that we always get stderr output (and no need for separate print() calls, and no need for
handle_message()function, probably also no need forhandle_error()function) - switch from print() to logging in dbsync.py as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows pyinstaller functions + logging
Fixes #99