Conversation
wonder-sk
reviewed
Jul 24, 2023
log_functions.py
Outdated
| msg.preamble = error | ||
|
|
||
| if date_time: | ||
| error = f"{date_time}: {error}" |
Contributor
There was a problem hiding this comment.
How much context is there in error ? A common issue may be that database schema has been modified. How would such an email look like?
Collaborator
Author
There was a problem hiding this comment.
The error may look like:
26/07/2023 11:59:36: geodiff failed!
['geodiff', 'diff', '--driver', 'postgres', 'host=localhost dbname=mergin_dbsync user=admin password='*****' port=5430', 'db_sync_base', 'db_sync_main', '/tmp/db-sync-dbsync-push-base2our']
wonder-sk
reviewed
Aug 4, 2023
Co-authored-by: Martin Dobias <wonder.sk@gmail.com>
Co-authored-by: Martin Dobias <wonder.sk@gmail.com>
Co-authored-by: Martin Dobias <wonder.sk@gmail.com>
Collaborator
Author
|
Should be all fixed |
wonder-sk
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Notification section to config, which if set up correctly will send email if sync has an error.
Fixes #56