Merged
Conversation
varmar05
reviewed
Jul 11, 2022
dbsync.py
Outdated
| _run_geodiff([config.geodiff_exe, "diff", "--driver", driver, conn_info, base, modified, changeset]) | ||
| def _geodiff_create_changeset(driver, conn_info, base, modified, changeset, ignored_tables): | ||
| if ignored_tables: | ||
| _run_geodiff([config.geodiff_exe, "diff", "--driver", driver, conn_info, "--skip-tables", ignored_tables, base, modified, changeset]) |
Contributor
There was a problem hiding this comment.
maybe pass this as arg to _run_geodiff or even would it be possible to read it from config and decide inside of _run_geodiff?
|
|
||
| mp = MerginProject(config.project_working_dir) | ||
| mp = MerginProject(work_dir) | ||
| mp.set_tables_to_skip(ignored_tables) |
Contributor
There was a problem hiding this comment.
I am wondering if there is a use case we need to remove/reset this settings or it is more like global settings for project in which case it might be better to pass it to constructor instead of having special method for that ...
varmar05
reviewed
Jul 11, 2022
| base: mergin_base | ||
| mergin_project: john/myproject | ||
| sync_file: sync.gpkg | ||
| skip_tables: |
Contributor
There was a problem hiding this comment.
just small note: does it work with some fancy tables names like 123MyAwesomeTable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to ignore tables when performin sync. Requires geodiff with MerginMaps/geodiff#182 and Python client with MerginMaps/python-api-client#147.
Temporarily contains commits from #69.
Fixes #62.