MerginCpp API and Refactoring 🥳 #1307
Merged
PeterPetrik merged 53 commits intomasterfrom Apr 12, 2021
Merged
Conversation
PeterPetrik
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all parts of refactoring (including all points fixed from #1293 ) and Mergin cpp api.
Commit containing Mergin cpp api: 13dfde6
All other commits contain refactoring. Commits from 557dfd1 contain UI fixes of #1293 + code cleanup and documentation (I tried to separate them ~ one fix = one commit ~ so it should be possible to review them commit by commit).
Screen_Recording_20210412-081555.1.mp4
Versions were also updated to 0.9.3
Resolves #379
Resolves #352
Resolves #1050
Also #1086 (if I understand it correctly, app now shows when project is being uploaded)