Merged
Conversation
Contributor
Withalion
commented
Sep 17, 2025
- Fixes rotation bug found during testing on samsung device
- Fixes clearing temporary sketched file when deleting file and also clears any saved sketches saved for that photo in session (when you load a photo, sketch it, remove the photo and load it again, there won't be any leftovers )
Missing metadata caused rotating images on mobile devices.
Pull Request Test Coverage Report for Build 18139696643Details
💛 - Coveralls |
tomasMizera
approved these changes
Oct 1, 2025
Collaborator
|
Some issues on mac: |
tomasMizera
requested changes
Oct 1, 2025
Collaborator
There was a problem hiding this comment.
The plan:
- catch errors on unsupported files - png, ...
- remove temp path if metadata could not be copied
- add support for png/heic (in 2025.7.0): #4125
- show notification if sketches could not be saved
Log exact Exiv error, remove temp sketched file on fail, show error notif for users
tomasMizera
approved these changes
Oct 2, 2025
Collaborator
|
Thanks for updating this one!:) |
Collaborator
|
Unrelated CI failure (Linux) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.