Skip to content

Fix photo sketching yet again#4109

Merged
tomasMizera merged 5 commits intomasterfrom
fix/photo-sketching-part-8
Oct 2, 2025
Merged

Fix photo sketching yet again#4109
tomasMizera merged 5 commits intomasterfrom
fix/photo-sketching-part-8

Conversation

@Withalion
Copy link
Contributor

  • Fixes rotation bug found during testing on samsung device
  • Fixes clearing temporary sketched file when deleting file and also clears any saved sketches saved for that photo in session (when you load a photo, sketch it, remove the photo and load it again, there won't be any leftovers )

Missing metadata caused rotating images on mobile devices.
@github-actions
Copy link

Pull Request Test Coverage Report for Build 18139696643

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 43 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 59.831%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/photosketchingcontroller.cpp 20 63.83%
input/app/imageutils.cpp 22 62.2%
Totals Coverage Status
Change from base Build 17734897568: -0.03%
Covered Lines: 8511
Relevant Lines: 14225

💛 - Coveralls

@tomasMizera
Copy link
Collaborator

Some issues on mac:

"2025-10-01T09:51:28.201Z copying EXIF: Failed to copy EXIF metadata\n"
"2025-10-01T09:51:28.201Z Photo sketching: Failed to copy metadata to: /private/var/folders/45/8r_wktb91y948vl2h526r32m0000gn/T/imagedemo/pixelme.png\n"

...

qrc:/com.merginmaps/imports/MMInput/form/components/MMFormPhotoSketchingPageDialog.qml:148: TypeError: Value is undefined and could not be converted to an object

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan:

  • catch errors on unsupported files - png, ...
  • remove temp path if metadata could not be copied
  • add support for png/heic (in 2025.7.0): #4125
  • show notification if sketches could not be saved

Log exact Exiv error, remove temp sketched file on fail, show error
notif for users
@Withalion Withalion requested a review from tomasMizera October 2, 2025 10:00
@tomasMizera
Copy link
Collaborator

Thanks for updating this one!:)

@tomasMizera
Copy link
Collaborator

Unrelated CI failure (Linux)

@tomasMizera tomasMizera merged commit 104fa9c into master Oct 2, 2025
8 of 9 checks passed
@tomasMizera tomasMizera deleted the fix/photo-sketching-part-8 branch October 2, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants