Conversation
Withalion
changed the title
Contributor
gabriel-bolbotina
left a comment
gabriel-bolbotina
left a comment
There was a problem hiding this comment.
Overall seems fine. I was wondering if we should also add/ update the unit test for this enhancement?
|
@Withalion we have tested the functionality and it seems to work fine, thanks! |
Contributor
Author
|
@gioman I'm happy to hear that, after some discussion with @tomasMizera we will add some more improvements to the autosync. |
📦 Build Artifacts Ready
|
This was
linked to
issues
Dec 12, 2025
Contributor
Author
|
@tomasMizera I fixed the missing banner, but I forgot what were the other issues. I'll fix them when you publish your review |
tomasMizera
requested changes
Dec 12, 2025
📦 Build Artifacts Ready
|
tomasMizera
reviewed
Dec 12, 2025
Contributor
Author
|
Change the option description in app settings to something more meaningful |
📦 Build Artifacts Ready
|
gabriel-bolbotina
pushed a commit
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4178
This PR adds new triggers for autosync when allowed:
Besides the triggers also UX was improved. With synchronizations triggered by autosync there won't be so much "visual smog" only notification about successful sync will be shown.